Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional header fixes #33

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Additional header fixes #33

merged 3 commits into from
Jan 11, 2024

Conversation

sirn-se
Copy link
Owner

@sirn-se sirn-se commented Jan 9, 2024

Additional fixes for HTTP headers. Now require non-empty array when setting header values as array.

Also some documentation touch up.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 26751d5 on headerfix
into 82a0166 on v2.1-main.

@sirn-se sirn-se linked an issue Jan 9, 2024 that may be closed by this pull request
@axklim
Copy link
Contributor

axklim commented Jan 10, 2024

I found that the examples in the documentation don't work well because the URL ws://echo.websocket.org/ was changed to wss://echo.websocket.org/ Since you are updating the docs in this pull request, could you please update the URLs accordingly? :)

@sirn-se
Copy link
Owner Author

sirn-se commented Jan 10, 2024

Oh, I haven't noticed they disabled ws:. Changing in the examples.

(Interestingly, using ws://echo.websocket.org do return a 301 Moved Permanently - but not to wss://echo.websocket.org as you might expect, but to https://echo.websocket.org.

@sirn-se sirn-se merged commit b59cf5d into v2.1-main Jan 11, 2024
14 checks passed
@sirn-se sirn-se deleted the headerfix branch January 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not allowed 0 (zero) value in headers
3 participants