TASK: Use @private instead of nested components #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
force-pushed
the
task/avoidNestedComponentsInFavorOfAtPrivateProps
branch
from
15c488d
to
25e1ee2
Compare
This will avoid the instantiation of a level of fusion objects and thus should improve performance
mficzel
force-pushed
the
task/avoidNestedComponentsInFavorOfAtPrivateProps
branch
from
750080b
to
1acc8f6
Compare
| @@ -5,51 +5,50 @@ prototype(Sitegeist.Kaleidoscope:Source) < prototype(Neos.Fusion:Component) { | |||
| } | |||
|
|
|||
| imageSource = null | |||
| [email protected] = ${value || __imageSource} | |||
There was a problem hiding this comment.
Where does this __imageSource come from?
There was a problem hiding this comment.
That is put into context from Picture so you do not have to specify it for every source when you do write sources as children like:
image = afx<Sitegeist.Kaleidoscope:Picture imageSource={props.source}> <Sitegeist.Kaleidoscope:Source format="webp" /> <Sitegeist.Kaleidoscope:Source format="png" /> </Sitegeist.Kaleidoscope:Picture>
There was a problem hiding this comment.
How does Eel interpret ||? What happens if value is false or null?
There was a problem hiding this comment.
If value is not null (exactly php falsy) the expression will yield value otherwise __imageSource
manuelmeister
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required Neos 8.3 + but should improve the performance as a level of fusion objects is avoided.