Conversation
|
Excellent! |
katdal/h5datav2_5.py
Outdated
|
|
||
| @property | ||
| def u(self): | ||
| raise NotImplementedError("File is AVN Single-dish format, uv-plane is not applicable.") |
There was a problem hiding this comment.
Or you could just return 0 :-)
There was a problem hiding this comment.
Would that be valid? I'm concerned that if a user unwittingly uses this, it may cause unexpected weird results.
There was a problem hiding this comment.
It should be. That's where single-dish data goes...
There was a problem hiding this comment.
Okay. Would that be true of u, v and w? Or just u?
There was a problem hiding this comment.
All of them. Just remember to return an array with the appropriate shape.
There was a problem hiding this comment.
Done in ca0e58d. Have I understood correctly? There's only one "baseline", so the array should really only have one dimension I think.
…to make_pmodel_string().
…Fixed typo in __init__ kwargs.
…s of the sampling frequency.
…nna from the dataset.
…ENSOR_PROPS update dictionary.
|
@ludwigschwardt I realise this is not a priority right now, but this PR has been dangling for quite a while. I don't really have an opinion either way - if more work is needed to clean it up, or if it should just be closed. What are your thoughts? |
2 participants
Inclusion of AVN datafile format for reduction of single-dish observations in Ghana.