fix: specimen source handling #22
Open
+11,930
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmcgrath13
requested review from
BobanL,
lina-roth,
angelathe,
gordonfarrell and
austin-hall-skylight
mcmcgrath13
force-pushed
the
mcm/fix-spec-source
branch
from
4fe184c to
7546817
Compare
BobanL
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the logic for finding the specimen source so that the order of components does not matter. Currently, if the specimen source isn't the last component, it will get wiped out by a later component. Also, make sure these variables don't leak outside of result handling and tighten the specimen extension inclusion to cases where there are a true specimen.
Add a snapshot test that covers these cases well/establish snapshot testing for eCRs.