Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken CI signals #296

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fixing broken CI signals #296

merged 1 commit into from
Dec 5, 2024

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Dec 5, 2024

No description provided.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.40%. Comparing base (480a326) to head (b9cf456).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ractor/src/factory/stats.rs 66.66% 2 Missing ⚠️
ractor/src/factory/factoryimpl.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   82.41%   82.40%   -0.01%     
==========================================
  Files          60       60              
  Lines       10899    10914      +15     
==========================================
+ Hits         8982     8994      +12     
- Misses       1917     1920       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slawlor slawlor force-pushed the ci_fixes branch 4 times, most recently from c0384ad to 24ac83c Compare December 5, 2024 17:54
Includes updating the generated test certificates for TLS integration tests and a minor addition for stats
@slawlor slawlor marked this pull request as ready for review December 5, 2024 17:58
@slawlor slawlor merged commit ceef493 into main Dec 5, 2024
13 checks passed
@slawlor slawlor deleted the ci_fixes branch December 5, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant