Conversation
|
It looks like Windows support for tokio based serial stuff can be worked on once tokio-rs/tokio#3760 is merged. This would be needed for Modbus RTU. I suppose Windows support should not be dropped from tokio-modbus, thus merging is blocked |
|
Hello ! tokio-rs/tokio#3760 was merged and released. |
|
@Tarnadas I just got the required PR for Windows compatibility into tokio-serial (berkowski/tokio-serial@693e7ee), with a follow-up PR likely to be merged soon (berkowski/tokio-serial#41) Could you already restructure your PR around that version of tokio-serial? |
Hey,
here is another attempt at updating tokio to v1.
Some remarks:
tokio-serialwithserial-io, a custom fork I made based onmio-serialandtokio-serial. It basically just adds tokio v1 support via a feature flag instead of splitting it into different crates. Also all other dependencies have been updated. I checked this PR and made sure that I fixed this.serial-iois slightly different.SerialtoAsyncSerial, because the regularSerialinserial-iohas no tokio support. I'm not sure, if I should change the name.Changelog:
closes #71 and #72