Skip to content

bump juno v0.12.5; bump starknet.go v0.8.0 #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

bump juno v0.12.5; bump starknet.go v0.8.0 #555

wants to merge 7 commits into from

Conversation

chray-zhang
Copy link
Contributor

@chray-zhang chray-zhang commented Nov 26, 2024 •
edited by augustbleeds
Loading

Supports:

core ref: 1aae11f92d492cb29d86d65b9de4235e1da8944d

@chray-zhang chray-zhang requested review from a team as code owners November 26, 2024 00:11
@chray-zhang chray-zhang mentioned this pull request Nov 26, 2024
Closed
@jmank88 jmank88 changed the title bump starknet.go v0.7.2; juno v0.12.0 bump juno v0.12.4 Nov 26, 2024
@jmank88 jmank88 changed the title bump juno v0.12.4 bump juno v0.12.4; bump starknet.go v0.7.2 Nov 26, 2024
jmank88
jmank88 reviewed Nov 26, 2024
View reviewed changes
relayer/pkg/starknet/client.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These had incompatibilities, but they were unused.

jmank88
jmank88 reviewed Nov 26, 2024
View reviewed changes
relayer/pkg/chainlink/txm/txm.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type was renamed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an earlier version, on the name had changed. Now the field names changed too, and my first attempt has led to nil pointers 🤦

  • use correct FeeEstimation fields

@jmank88
Copy link
Contributor

jmank88 commented Nov 26, 2024

The txm is constructing a InvokeTxnV3 but AddInvokeTransaction now expects a rpc.BroadcastInvokeTxnType

@jmank88 jmank88 force-pushed the bump-juno branch 2 times, most recently from 4d70695 to 56f326b Compare January 15, 2025 14:16
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
5.7% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 13, 2025
@github-actions GitHub Actions
Copy link

This PR has been automatically closed because it has been stale for > 30 days.
If you wish to continue working on this PR, please reopen it and make any necessary changes.

@github-actions github-actions bot closed this Jun 20, 2025
@github-actions github-actions bot deleted the bump-juno branch June 20, 2025 00:48
@jmank88 jmank88 removed the Stale label Jun 20, 2025
@jmank88 jmank88 restored the bump-juno branch June 20, 2025 01:16
@jmank88 jmank88 reopened this Jun 20, 2025
@jmank88 jmank88 requested a review from a team as a code owner June 20, 2025 01:16
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 21, 2025
@jmank88 jmank88 removed the Stale label Jul 22, 2025
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 22, 2025
@jmank88 jmank88 removed the Stale label Aug 22, 2025
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 22, 2025
@jmank88 jmank88 removed the Stale label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 left review comments

@augustbleeds augustbleeds augustbleeds requested changes

@ilija42 ilija42 ilija42 left review comments

@skudasov skudasov Awaiting requested review from skudasov

@smickovskid smickovskid Awaiting requested review from smickovskid

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chray-zhang @jmank88 @augustbleeds @ilija42