Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaDraw Bug Fix(es) and QOL Update #2420

Merged
merged 24 commits into from
Sep 25, 2024

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Sep 18, 2024

Addressed a few bugs after release and added one feature.

Can now select a custom PPM tolerance in MetaDraw for fragmentation reanalysis.

Defaulted to 20 ppm

Bug Cause: Loading MetaDraw with an old config file

Previous Behavior

  • Default all to a standard color (e.g. aqua)

New Behavior

  • Salvage what you can from old config file, replace rest with MetaDraw defaults, replace old config file with modern variant.

Bug Cause: Switching to chimeric scan view from child scan view when displaying an ambiguous result

Previous Behavior

  • Crashes due to our visualization spaghetti code

New Behavior

  • Does not, with even more spaghetti

@nbollis nbollis added Bug WIP Work in progress, not ready for review Visualization labels Sep 18, 2024
@nbollis nbollis linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (e1c39e7) to head (b17cc03).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2420      +/-   ##
==========================================
+ Coverage   93.65%   93.67%   +0.02%     
==========================================
  Files         141      141              
  Lines       21903    21928      +25     
  Branches     3004     3007       +3     
==========================================
+ Hits        20513    20542      +29     
+ Misses        938      934       -4     
  Partials      452      452              
Flag Coverage Δ
93.67% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...entResearching/FragmentationReanalysisViewModel.cs 96.11% <100.00%> (+0.19%) ⬆️
...etaMorpheus/GuiFunctions/MetaDraw/MetaDrawLogic.cs 95.63% <100.00%> (ø)
...Morpheus/GuiFunctions/MetaDraw/MetaDrawSettings.cs 98.52% <100.00%> (+0.93%) ⬆️
...iFunctions/ViewModels/MetaDrawSettingsViewModel.cs 98.41% <100.00%> (+0.02%) ⬆️

@nbollis nbollis changed the title Meta draw bug fixes post 1.0.6 release MetaDraw Updates Sep 19, 2024
@nbollis nbollis changed the title MetaDraw Updates MetaDraw Bug Fix(es) and QOL Update Sep 19, 2024
@nbollis nbollis marked this pull request as ready for review September 19, 2024 17:09
@nbollis nbollis added ready for review and removed WIP Work in progress, not ready for review labels Sep 19, 2024
@nbollis nbollis merged commit 6dd10e0 into smith-chem-wisc:master Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetaDraw crashed while attempting to open the Chimeric Scan View.
4 participants