-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetaDraw Bug Fix(es) and QOL Update #2420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated to MzLib 1.0.548 and fixed custom ions in search tasks * reverted calibration task change * merged in master bbbyy * Enabled Library Loading from command line
…a uniform default
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2420 +/- ##
==========================================
+ Coverage 93.65% 93.67% +0.02%
==========================================
Files 141 141
Lines 21903 21928 +25
Branches 3004 3007 +3
==========================================
+ Hits 20513 20542 +29
+ Misses 938 934 -4
Partials 452 452
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nbollis
requested review from
Alexander-Sol,
elaboy,
mzhastings,
trishorts and
zhuoxinshi
September 19, 2024 17:10
zhuoxinshi
approved these changes
Sep 19, 2024
nbollis
added
ready for review
and removed
WIP
Work in progress, not ready for review
labels
Sep 19, 2024
Alexander-Sol
approved these changes
Sep 23, 2024
trishorts
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed a few bugs after release and added one feature.
Can now select a custom PPM tolerance in MetaDraw for fragmentation reanalysis.
Defaulted to 20 ppm
Bug Cause: Loading MetaDraw with an old config file
Previous Behavior
New Behavior
Bug Cause: Switching to chimeric scan view from child scan view when displaying an ambiguous result
Previous Behavior
New Behavior