Updated FilteredPsms to only iterate through PSMs once #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2430 +/- ##
=======================================
Coverage 93.72% 93.73%
=======================================
Files 141 141
Lines 21865 21871 +6
Branches 3000 2998 -2
=======================================
+ Hits 20493 20500 +7
Misses 922 922
+ Partials 450 449 -1
|
RayMSMS
approved these changes
Oct 28, 2024
zhuoxinshi
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when filtering, we iterated through the list of PSMs 6 times. Now, we only iterate through once in a single LINQ statement. This should give a modest performance increase.