Update Numerical Inputs #2433
Merged
Update Numerical Inputs #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated to MzLib 1.0.548 and fixed custom ions in search tasks * reverted calibration task change * merged in master bbbyy * Enabled Library Loading from command line
- Added `HorizontalContentAlignment` and `VerticalContentAlignment` properties to center content in `DoubleTextBoxControl` and `IntegerTextBoxControl`. - Introduced constructors to set alignment properties. - Overrode `OnKeyDown` to clear focus on Return key press. - Included `System.Windows` namespace in both control files.
Replaced standard TextBox controls with custom IntegerTexBoxControl and DoubleTextBoxControl in various XAML files to improve input validation and user experience. Removed the CheckIfNumber event handler and method from code-behind files as the new custom controls handle validation internally. Updated tooltips and adjusted layout properties for consistency.
trishorts
approved these changes
Oct 31, 2024
RayMSMS
approved these changes
Oct 31, 2024
elaboy
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often have bug reports where the value restriction is incorrect in GUI numerical boxes. This is due to having method that check if something is either a positive integer, or a number. These methods were called interchangeably from the same syntax in the xaml.
IntegerTexBoxControlandDoubleTextBoxControlwere updated to automatically center the data in the box and remove your cursor from the box when you hit enterCalibrateTaskWindow.xaml,GPTMDTaskWindow.xaml,GlycoSearchTaskWindow.xaml,SearchTaskWinodow.xaml, andFileSpecificParametersWindow.xaml: ReplacedTextBoxwithIntegerTexBoxControlandDoubleTextBoxControlwhere appropriateCheckIfNumbermethod from corresponding code-behind files.