Mod_Pair part1 ModBox and Reader #2516
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2516 +/- ##
==========================================
+ Coverage 96.56% 96.60% +0.04%
==========================================
Files 147 148 +1
Lines 21976 22149 +173
Branches 3058 3080 +22
==========================================
+ Hits 21221 21397 +176
+ Misses 750 747 -3
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
RayMSMS
added
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is the series of PR for Mod_Pair
In the first part, I created two new classes
ModBox:
The container of Modification. (Like glycan box but can include regular modification)
ModDatabaseReader:
The reader can load the mod database and store the mod in a different category. After loading the mod, Reader will build the ModBox depending on all combination mods in the database.
I also included the testers for the two classes.