-
Notifications
You must be signed in to change notification settings - Fork 47
Deconvolution Visualization #2562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nbollis
wants to merge
16
commits into
smith-chem-wisc:master
Choose a base branch
from
nbollis:DeconExploration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+982
−238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pheus into DeconExploration
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2562 +/- ##
==========================================
+ Coverage 96.83% 96.84% +0.01%
==========================================
Files 158 163 +5
Lines 23569 23745 +176
Branches 3280 3306 +26
==========================================
+ Hits 22824 22997 +173
- Misses 740 743 +3
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new tab to MetaDraw to see how our deconvolution works on different scans.
There are two modes: Full Spectrum, and Isolation Window
Changes to existing code:
Broke out
MassSpectrumPlot
as a parent class toSpectrumMatchPlot
Removed all explicit axis tick labeling -> it now does it automatically based upon your zoom.