-
Notifications
You must be signed in to change notification settings - Fork 49
MetaDraw Update - Data Loading Refactor, Chimera Tab, BioPolymer Tab #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…pheus into DeconExploration
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2567 +/- ##
=========================================
Coverage 96.83% 96.83%
=========================================
Files 162 174 +12
Lines 23850 25216 +1366
Branches 3316 3484 +168
=========================================
+ Hits 23095 24418 +1323
- Misses 750 793 +43
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR significantly refactors MetaDraw's data loading architecture and adds two major new visualization tabs while improving the overall user experience.
Key Changes:
- Refactored data loading into a dedicated asynchronous
MetaDrawDataLoader
class with progress visualization - Added a new Chimera Annotation tab for visualizing deconvolution results of MS spectra
- Added a new BioPolymer Coverage tab for protein sequence coverage visualization with customizable coloring
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated 7 comments.
Show a summary per file
File | Description |
---|---|
MetaDrawDataLoader.cs | New dedicated data loader class handling asynchronous loading of spectra, PSMs, and libraries with progress tracking |
MetaDrawLogic.cs | Refactored to use new data loader and moved loading methods to dedicated class |
DeconExplorationTabViewModel.cs | New tab for deconvolution visualization with full spectrum and isolation region modes |
BioPolymerTabViewModel.cs | New tab for protein sequence coverage analysis with database loading and filtering |
BioPolymerCoverageMapViewModel.cs | Visualization component for protein coverage with customizable coloring by coverage type or file origin |
MetaDrawSettings.cs | Added new settings for BioPolymer coverage colors and font size |
SpectrumMatchPlot.cs | Refactored to inherit from new MassSpectrumPlot base class |
MetaDraw.xaml.cs | Updated to use new data loader and initialize new tab view models |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
MetaMorpheus/GuiFunctions/MetaDraw/BioPolymerCoverage/BioPolymerGroupViewModel.cs
Outdated
Show resolved
Hide resolved
MetaMorpheus/GuiFunctions/MetaDraw/BioPolymerCoverage/BioPolymerTabViewModel.cs
Show resolved
Hide resolved
MetaMorpheus/GuiFunctions/MetaDraw/BioPolymerCoverage/BioPolymerTabViewModel.cs
Outdated
Show resolved
Hide resolved
MetaMorpheus/GUI/Util/Converters/StringIsNotNullOrEmptyToBoolConverter.cs
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…erGroupViewModel.cs Co-authored-by: Copilot <[email protected]>
…erTabViewModel.cs Co-authored-by: Copilot <[email protected]>
|
This PR does 3 major things.
Refactor MetaDraw Data loading
Data Loading is now performed in a dedicated class
Removed the second data loading method from
MetaDraw.xaml.cs
Loading of PSMs and Spectra occurs first, then the other tabs load asynchronously
While the other tabs are loading in the background, they are disabled in the GUI
Created singleton
LoadingProgressViewModel
to handle the load state of different MetaDraw tabs.Created parent
MetaDrawTabViewModel
to handle loading GUI responses.Deconvolution Visualization
BioPolymer Coverage Visualization
Other changes to make this PR possible
SpectrumMatchPlot
to handle basic spectral plotting.MetaDrawTabViewModel
to handle