Skip to content

Refactor Github Action - Test #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor Github Action - Test #2570

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9de63d2
Refactor test command and coverage file path
Alexander-Sol Sep 19, 2025
f5afbfb
Remove configuration option from build step
Alexander-Sol Sep 19, 2025
53d0ad4
Update coverage file path in Test.yml
Alexander-Sol Sep 19, 2025
51e3b02
Merge branch 'master' into CodeCovFix
trishorts Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@ jobs:
run: dotnet restore ./MetaMorpheus/MetaMorpheus.sln

- name: Build
run: dotnet build --no-restore ./MetaMorpheus/MetaMorpheus.sln --configuration Release
run: dotnet build --no-restore ./MetaMorpheus/MetaMorpheus.sln

- name: Install Coverlet for code coverage
run: dotnet add ./MetaMorpheus/Test/Test.csproj package coverlet.collector -v 6.0.2

- name: Run unit tests with coverage
run: dotnet test .\MetaMorpheus\Test\Test.csproj --configuration Release --verbosity normal --collect:"XPlat Code Coverage"
run: cd MetaMorpheus && dotnet test --no-build --verbosity normal --collect:"XPlat Code Coverage" /p:CoverletOutputFormat=cobertura ./Test/Test.csproj
Copy link
Preview

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --no-build flag is used but the build step was changed to remove the --configuration Release flag. This creates a mismatch where the build step builds in Debug configuration but the test step expects a Release build, which may cause the tests to fail.

Copilot uses AI. Check for mistakes.


- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
flags: unittests
files: MetaMorpheus/Test*/TestResults/*/coverage.cobertura.xml
Copy link
Preview

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The wildcard pattern Test* may match unintended directories. Consider using a more specific pattern like Test/TestResults/*/coverage.cobertura.xml to avoid potential issues with similarly named directories.

Suggested change
files: MetaMorpheus/Test*/TestResults/*/coverage.cobertura.xml
files: MetaMorpheus/Test/TestResults/*/coverage.cobertura.xml

Copilot uses AI. Check for mistakes.

Loading