SNOW-1524259: Add option to build libsnowflakeclient as dynamic library #782
+463
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-jl
force-pushed
the
SNOW-1524259-dynamic-library
branch
from
f7fcd62 to
e95c698
Compare
sfc-gh-ext-simba-jl
force-pushed
the
SNOW-1524259-dynamic-library
branch
from
0f57b57 to
e95c698
Compare
sfc-gh-ext-simba-jl
requested review from
sfc-gh-dprzybysz and
sfc-gh-jszczerbinski
sfc-gh-dprzybysz
changed the title
| sf_get_tmp_dir @74 | ||
| sf_calloc @75 | ||
| sf_free @76 | ||
| uuid4_generate @77 |
There was a problem hiding this comment.
we will need to update the exports whenever the public api is changed or we can make it dynamically created?
There was a problem hiding this comment.
The exports are currently manually created (same as the ODBC driver) as we don't want to expose internal functions. There are tools that can generate the exports file but I'm not sure if they can build. I'll test it out and get back to you.
| ../deps-build/${PLATFORM}/${VSDIR}/${CMAKE_BUILD_TYPE}/cmocka/include | ||
| ) | ||
| set_target_properties( | ||
| ${T} PROPERTIES LINK_FLAGS "/ignore:4099") |
There was a problem hiding this comment.
why do we need this ignore?
There was a problem hiding this comment.
Removed. It's not needed here.
…wflakedb/libsnowflakeclient into SNOW-1524259-dynamic-library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teamwork issue 1033
Add support for building libsnowflakeclient as a dynamic linking library.