Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1524259: Add option to build libsnowflakeclient as dynamic library #782

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
b020c2d
Rebase from master to branch
sfc-gh-ext-simba-hx Aug 7, 2024
55fcb5c
update for Linux build
SimbaGithub Aug 8, 2024
8e8411c
copy the dynamic lib to deps-build folder
sfc-gh-ext-simba-jl Nov 26, 2024
9aa79b0
fix undefined reference error on linux
sfc-gh-ext-simba-jl Nov 26, 2024
09b7185
fix copy error on linux
sfc-gh-ext-simba-jl Nov 27, 2024
e95c698
fix mac build
sfc-gh-ext-simba-jl Nov 28, 2024
bfcc89b
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Jan 9, 2025
f5c24a3
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Jan 9, 2025
f562da7
update all export files and link tests to both static and dynamic lib…
sfc-gh-ext-simba-jl Jan 10, 2025
100791a
fix windows build error
sfc-gh-ext-simba-jl Jan 10, 2025
3860a1e
fix linux and mac dynamic lib build and fix windows dynamic lib tests
sfc-gh-ext-simba-jl Jan 14, 2025
e655135
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Jan 14, 2025
519196a
move test_unit_privatelink to TESTS_C_UNIT
sfc-gh-ext-simba-jl Jan 14, 2025
53a6957
remove thirdparty deps when dynamically linking the tests
sfc-gh-ext-simba-jl Jan 16, 2025
75698f8
fix the linking to snowflake_dynamic for tests
sfc-gh-ext-simba-jl Jan 16, 2025
fceed68
link dynamic test to dynamic lib only
sfc-gh-ext-simba-jl Jan 21, 2025
bd41551
fix dynamic test failure
sfc-gh-ext-simba-jl Jan 22, 2025
f3485f2
enable debug logging for windows test
sfc-gh-ext-simba-jl Jan 22, 2025
c421af2
fix running dynamic test on mac
sfc-gh-ext-simba-jl Jan 24, 2025
327d68b
fix mac test failure
sfc-gh-ext-simba-jl Jan 24, 2025
aed384e
disbable logging on windows
sfc-gh-ext-simba-jl Jan 24, 2025
eb61ddc
debug - disable two failing tests
sfc-gh-ext-simba-jl Jan 24, 2025
80a5c16
debug - enable test_large_result_set
sfc-gh-ext-simba-jl Jan 24, 2025
e1185d6
debug - enable test_crud and disable test_large_result_set
sfc-gh-ext-simba-jl Jan 24, 2025
da91611
debug - enable logging for test_crud
sfc-gh-ext-simba-jl Jan 25, 2025
b7b5a22
remove logging
sfc-gh-ext-simba-jl Jan 27, 2025
94dc044
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Jan 27, 2025
93cd64b
update cmake to restrict changes to dynamic lib only
sfc-gh-ext-simba-jl Jan 28, 2025
cc81459
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Jan 28, 2025
091eb16
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Jan 28, 2025
dacc4a6
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Jan 28, 2025
d006d16
remove ignore 4099 flag in dynamic linking test
sfc-gh-ext-simba-jl Jan 30, 2025
c7fe9a0
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Jan 30, 2025
1e6d91b
Merge branch 'SNOW-1524259-dynamic-library' of https://github.com/sno…
sfc-gh-ext-simba-jl Jan 30, 2025
d991291
revert changes in test cmakelist
sfc-gh-ext-simba-jl Jan 30, 2025
0cf2aa3
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Jan 31, 2025
b2e0fb1
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Feb 4, 2025
949ed6a
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Feb 6, 2025
ed6cd40
fix build error
sfc-gh-ext-simba-jl Feb 7, 2025
ab22a7d
remove ignore from cmake and fix test failure
sfc-gh-ext-simba-jl Feb 7, 2025
bc99755
use dllexport/visibility instead of exports
sfc-gh-ext-simba-jl Feb 8, 2025
73d89ac
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Feb 10, 2025
ca4e6bd
fix mac build and expose and hide functions as requested
sfc-gh-ext-simba-jl Feb 12, 2025
aa3248a
separate static/dynamic build and tests and update artifacts name
sfc-gh-ext-simba-jl Feb 15, 2025
7caae7c
fix windows test issue and linux/mac builds
sfc-gh-ext-simba-jl Feb 17, 2025
bb619fc
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Feb 18, 2025
7d05412
replace free() with SF_FREE() in tests
sfc-gh-ext-simba-jl Feb 19, 2025
be50fcf
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Feb 20, 2025
d48b765
add BUILDING_LIBSFC to restrict exporting public functions when build…
sfc-gh-ext-simba-jl Feb 21, 2025
c061a4f
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-hx Mar 4, 2025
f58ccb6
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl Mar 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into SNOW-1524259-dynamic-library
sfc-gh-ext-simba-jl authored Jan 28, 2025
commit 091eb16a2c99c77c87e711e0d99468d91d268781

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.