fix(iOS): Verify that ScrollView gesture hasn't begun when triggering pan gesture #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmichalikk
changed the title
kligarski
approved these changes
Oct 13, 2025
kkafar
requested changes
Oct 21, 2025
t0maboro
approved these changes
Oct 23, 2025
kkafar
reviewed
Oct 23, 2025
kmichalikk
force-pushed
the
@kmichalikk/custom-gesture-recognizer-horizontal-scroll-ios26
branch
from
b619cff to
9f9dc04
Compare
kmichalikk
deleted the
@kmichalikk/custom-gesture-recognizer-horizontal-scroll-ios26
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/software-mansion/react-native-screens-labs/issues/489
Description
This PR addresses the issue that, when using custom PanGestureRecognizer on iOS 26 (for handling custom animations on swipe) with a screen that has a horizontal ScrollView, and when swiping for the second time before the view stopped scrolling, the screen is popped with pan gesture.
Changes
Added check for ScrollGestureRecognizer state=Began in
shouldRecognizeSimultaneouslyWithGestureRecognizerto return NO.sv-custom-horizontal-bad.mov
sv-custom-horizontal-good.mov
-->
Test code and steps to reproduce
Use Test3265 on iOS 26; make sure that the screen has
animationset to custom animation andanimationMatchesGesture: true.