feat(cli): add --artifacts-path flag to override .so program location#573
Open
procdump wants to merge 2 commits intosolana-foundation:mainfrom
Open
feat(cli): add --artifacts-path flag to override .so program location#573procdump wants to merge 2 commits intosolana-foundation:mainfrom
procdump wants to merge 2 commits intosolana-foundation:mainfrom
Conversation
Allow overriding the default `target/deploy` path for .so artifacts with `--artifacts-path`. This enables loading debug-compiled programs during local development (e.g. `surfpool start --artifacts-path ./target/deploy/debug`). The flag conflicts with `--network` to prevent deploying debug builds to mainnet/devnet/testnet. Threads artifacts_path through framework detection, .so existence checks, in-memory template generation (bin_path injection), and the file watcher.
Allow overriding the default target/deploy path for .so program artifacts. Deployment always targets the local surfnet regardless of --network or --rpc-url, so no conflicts are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo-build-sbf --debugemits artifacts intarget/deploy/debugon purpose to prevent accidental deployments on mainnet so in that sense:--artifacts-pathCLI flag to support loading debug-compiled.soprograms (e.g.surfpool start --artifacts-path ./target/deploy/debug)artifacts_paththrough framework detection,.soexistence checks, in-memory template generation, and the--watchfile watcherWhile working on this PR I've unearthed a calculation overflow bug in
txtx-addon-network-svm(details in the PR): solana-foundation/txtx#399