fix: skip cleanup transaction check for cheatcode deployments#399
Open
procdump wants to merge 1 commit intosolana-foundation:mainfrom
Open
fix: skip cleanup transaction check for cheatcode deployments#399procdump wants to merge 1 commit intosolana-foundation:mainfrom
procdump wants to merge 1 commit intosolana-foundation:mainfrom
Conversation
The `only_cleanup_transactions_remaining` subtraction overflows when `instant_surfnet_deployment = true` because the cheatcode path produces only 1 transaction, and the code unconditionally subtracts 4. Cheatcode deployments return no cleanup transactions, so the check should not apply to them.
Author
|
This PR came from my attempt to introduce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
deploy_program.rswheninstant_surfnet_deployment = trueonly_cleanup_transactions_remainingunconditionally subtractsget_cleanup_transactions_count() + 1(= 4) from the transaction count, causing a panicget_cleanup_transactionsreturnsvec![]whendo_cheatcode_deployis true), so the check is skipped entirely for that pathReproduction
instant_surfnet_deployment = true(the default forsurfpool start)deploy_program.rs:308with "attempt to subtract with overflow"