Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SFT-1418): multiple instanced fields on events not saving values in Craft 5 #323

Open
wants to merge 2 commits into
base: v5
Choose a base branch
from
Open

fix(SFT-1418): multiple instanced fields on events not saving values in Craft 5 #323

wants to merge 2 commits into from
+18 −64

Conversation

seandelaney
Copy link
Contributor

@seandelaney seandelaney commented Sep 17, 2024 •
edited
Loading

Fixes #315

gustavs-gutmanis
gustavs-gutmanis reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@gustavs-gutmanis gustavs-gutmanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work in Craft 4 still?

@seandelaney
fix(SFT-1418): Fixing 'ICS Description field' and 'ICS Location field…
2fb5486 
…' dropdowns not show multiple instanced fields in Calendar settings in Craft 5
@seandelaney
Copy link
Contributor Author

@gustavs-gutmanis

Does this work in Craft 4 still?

Yes. Tested in Craft 4 and Craft 5. Note in Craft 4, you cannot drag the same field twice into the layout field editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavs-gutmanis gustavs-gutmanis gustavs-gutmanis approved these changes

@kjmartens kjmartens Awaiting requested review from kjmartens

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Craft 5 - Multiple instanced fields on events will not save values
2 participants
@seandelaney @gustavs-gutmanis