Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SFT-1418): multiple instanced fields on events not saving values in Craft 5 #323

Open
wants to merge 2 commits into
base: v5
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/plugin/src/Elements/Event.php
Original file line number Diff line number Diff line change
Expand Up @@ -1534,11 +1534,11 @@ public function setFieldValuesFromRequest(string $paramNamespace = ''): void
$processedAnyFields = false;
foreach ($this->fieldLayoutFields(true) as $field) {
// Have we already processed this field?
if (isset($processedFields[$field->id])) {
if (isset($processedFields[$field->handle])) {
continue;
}

$processedFields[$field->id] = true;
$processedFields[$field->handle] = true;
$processedAnyFields = true;

// Do we have any post data for this field?
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/src/Models/CalendarModel.php
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public function getIcsTimezone(): string

public function getDescriptionFieldHandles(): array
{
$fieldList = [Calendar::t('None')];
$fieldList = [];
if ($this->getFieldLayout()) {
foreach ($this->getFieldLayout()->getCustomFields() as $field) {
$fieldList[$field->handle] = $field->name;
Expand Down
1 change: 0 additions & 1 deletion packages/plugin/src/Resources/js/scripts/calendars/edit.js

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/plugin/src/Resources/js/scripts/calendars/main.js

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/plugin/src/Resources/js/scripts/events/edit.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/plugin/src/Resources/js/scripts/events/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading