[component] Grab tmpdir from policy#4062
Merged
Merged
Conversation
Rather than using /var/tmp by default, grab the tmp_dir from the policy. The default will be from tempfile.gettempdir() from the sos.policies, so should be getting it from the OS default. Closes: sosreport#4061 Signed-off-by: Arif Ali <arif.ali@canonical.com>
arif-ali
added
Status/Needs Review
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
2 similar comments
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
TurboTurtle
approved these changes
Jun 20, 2025
TurboTurtle
added
Reviewed/Ready for Merge
|
This change made sosreport unpredictable, and putting reports into /tmp (tmpfs) by default is conceptually wrong. Please see #4074 for details. |
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this pull request
Jul 9, 2025
sos 4.6.2 changed the tmp dir policy [1] from a static /var/tmp to a dynamic per-distro policy, which happens to be /tmp on Debian/Ubuntu right now. This is wrong, and there is no official way to query it [2]. To cope, query the sos policy for the tmp-dir, and only fall back to static /var/tmp if that fails. [1] sosreport/sos#4062 [2] sosreport/sos#4074
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this pull request
Jul 9, 2025
sos 4.6.2 changed the tmp dir policy [1] from a static /var/tmp to a dynamic per-distro policy, which happens to be /tmp on Debian/Ubuntu right now. This is wrong, and there is no official way to query it [2]. To cope, query the sos policy for the tmp-dir, and only fall back to static /var/tmp if that fails. [1] sosreport/sos#4062 [2] sosreport/sos#4074
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this pull request
Jul 9, 2025
sos 4.6.2 changed the tmp dir policy [1] from a static /var/tmp to a dynamic per-distro policy, which happens to be /tmp on Debian/Ubuntu right now. This is wrong, and there is no official way to query it [2]. To cope, query the sos policy for the tmp-dir, and only fall back to static /var/tmp if that fails. [1] sosreport/sos#4062 [2] sosreport/sos#4074
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this pull request
Jul 9, 2025
sos 4.6.2 changed the tmp dir policy [1] from a static /var/tmp to a dynamic per-distro policy, which happens to be /tmp on Debian/Ubuntu right now. This is wrong, and there is no official way to query it [2]. To cope, query the sos policy for the tmp-dir, and only fall back to static /var/tmp if that fails. [1] sosreport/sos#4062 [2] sosreport/sos#4074
martinpitt
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Jul 9, 2025
sos 4.6.2 changed the tmp dir policy [1] from a static /var/tmp to a dynamic per-distro policy, which happens to be /tmp on Debian/Ubuntu right now. This is wrong, and there is no official way to query it [2]. To cope, query the sos policy for the tmp-dir, and only fall back to static /var/tmp if that fails. [1] sosreport/sos#4062 [2] sosreport/sos#4074
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than using /var/tmp by default, grab the tmp_dir from the policy. The default will be from tempfile.gettempdir() from the sos.policies, so should be getting it from the OS default.
Closes: #4061
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines