[report] Fix formatting of distros in plugins_overview

[jcastill]

The formatting of the distros column was leaving the string 'Plu' when it found 'PluginOpt'. This fix
explicitly deals with both 'PluginOpt' and 'Plugin' strings and removes them.

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname email@example.com?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
• Are all passwords or private data gathered by this PR obfuscated?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-4071
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[arif-ali]

I never used the plugins_overview in the past, so looking into it, there's probably other fixes we ought to do as well, as there are other issues too

If the sos.report.plugins import is the only line, and then there is a comment/variables before the class deceleration, then we'll see the whole comment.

• authd
• kubernetes
• charmed_postgresql
• openstacK_instack
• openstack_mistral
• origin
• validation_framework
• vdsm

Either we update these plugins so that we don't have that, or we fix the plugins_overview.py; Personally, I wpuld lean towards fixing the plugins_overview.py

thoughts?

[jcastill]

I agree, I think fixing plugins_overview.py may be the way to go.

[jcastill]

This version should address the issues you found in the other plugins @arif-ali

[arif-ali]

I just found one more scenario

from sos.report.plugins import Plugin, RedHatPlugin, \
    DebianPlugin, UbuntuPlugin, CosPlugin

You then get the following in the distros list

"\    Debian"

I found 2 scenarios of this, apologies I didn't find this one earlier

[jcastill]

No apologies needed at all @arif-ali , and thank you for taking the time to check this.
Somehow I didn't catch these either in the csv and json outputs. I'll work on this tomorrow.

[jcastill]

@arif-ali I was thinking... it may be better to change the way we import in these two places (I've found kdump and release plugins, let me know if you found others) so it's consistent with the other plugins' imports of using parenthesis for multi-line imports?
I'll open a new PR for that, but feel free to close it if you think it makes no sense.

[arif-ali]

now that the other PR is done, this should be all good now

[pmoravec]

Merged via 82fc1a9.