Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New salvage expedition ambience, the second. #32437

Closed
wants to merge 1 commit into from
Closed

New salvage expedition ambience, the second. #32437

wants to merge 1 commit into from

Conversation

Sadie-silly
Copy link
Contributor

About the PR

adds a new song to the salvage expedition

Media

Ashwalking.mp4

Requirements

Changelog

🆑

  • add: Added another song while salvaging.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Sep 25, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 22, 2024
@Sadie-silly
Copy link
Contributor Author

I just realized, why'd this get "Visual Change" tag? This doesn't change any actual sprites in game, it's just a song.

@TheShuEd
Copy link
Member

TheShuEd commented Dec 20, 2024 •
edited
Loading

we have music freeze right now, sorry

#8524

@TheShuEd TheShuEd closed this Dec 20, 2024
@Sadie-silly
Copy link
Contributor Author

that's alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sadie-silly @TheShuEd @eoineoineoin @SlamBamActionman