contraband system for reagents

[Ian321]

About the PR

This PR adds the ability to classify reagents and their contraband status with the help of forensic pads.

Fixes #31383
Fixes #32218

(there where more issues, but i can't find them)

Why / Balance

It was previously not possible to mark a reagent as contraband.

I have only added lead, romerol, vestine and its derivatives as syndicate contraband for the start as I feel those are uncontroversial.

Technical details

• Modified the ForensicPadSystem to "scan" drainable/drawable containers (puddles, beakers, syringes, ...).
• Added a new datafield "Contraband" to reagents. (I would of loved to re-use the other system, but reagents can't have components.)
• Expanded the guidebook entry for forensics.
• Expanded the guidebook for chemicals.

Media

Screencast.From.2024-11-05.20-49-41.mp4

Screencast.From.2024-11-06.13-53-11.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None.

Changelog

🆑

• add: Chemicals can now be contraband.
• add: Forensic pads can now also be used to identify and classify chemicals.
• add: Chemical pads can be used to identify chemicals.

[Ian321]

Could in theory also encode the "GrandTheft" severity. Could make for an interesting objective: "Steal 10u of liquid youth from the command bar/vault.".

[YotaXP]

Not in the scope of this PR, but perhaps there should be a new contraband category for prescription drugs that doctors are allowed to grant permission to possess.

[Djungelskog2]

holy guacamole a reason to use forensic pads

[slarticodefast]

Very useful feature in my opinion. I found a few nitpicks that need to be corrected. I will check with the other maintainers and admins if this implementation is a good approach since the contraband system is quite connected to our server rules.

[Ian321]

The failed test DeleteAllThenGhost is unrelated and passed on my machine.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Ian321]

Why the hell is there a conflict? Nothing changed in contraband-severity.ftl.
Edit: Found the change. There was a BOM in the first line and it got removed by #33435. Time to rebase using a hex editor... AFTER a maintainer requests it.

[Ian321]

I'm starting to have some mixed feeling about this PR after having played some more botany and getting mutations that added would-be-contraband reagents multiple time. For example: Should I have to toss my ambrosia-dues, just because it also contains Stimulants/Hyperzine?

I'm assuming that's also why its still under maintainer discussion. Maybe this needs #33385 and/or a general free-pass for botany and chem?

[slarticodefast]

I'm assuming that's also why its still under maintainer discussion. Maybe this needs #33385 and/or a general free-pass for botany and chem?

Yeah, that's one of the points, but the discussion has stalled a little, I'll give it a bump. Some points we got so far:

• Lead should likely not be contraband, even if it is a strong poison and only available for nukies, since it is also a common material in real life and it being prohibited does not really make much sense. Long term a lot of chemicals will have to be rebalanced anyways, but probably after newmed and the chem refactor.
• Like you mentioned, a lot of discussion will be needed for other reagents, for example uranium, mutagen, plasma and so on. They all can be dangerous and could be considered contraband, but would need to be classified if that is something we want to have for reagents.
• In combination with the linked PR some reagents might only be allowed for certain jobs.

In any case, I think having the functionality for this in the game should be a good thing, no matter the exact classifications we come up with. For the start we can stick to the obvious highly prohibitied traitor-only reagents that are syndicate contraband and maybe add minor categories later.

I will give the PR another review when I find the time.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Ian321]

@slarticodefast I have a suggestion:

1. i'll wait for Job contraband rework #33385
2. rebase
3. add fields to specify allowed departments and jobs
4. remove the fields already assigned (so no reagent is contraband)

This way we could merge this and have another (multiple?) PR decide what is considered contraband.

[slarticodefast]

Sounds like a good plan to me 👍

[IProduceWidgets]

I think this should be its own component. It doesn't really make any sense to tie it to fingerprinting and DNA at all.

[github-actions]

RSI Diff Bot; head commit 08dcc3b merging into 332fc18
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Storage/boxes.rsi

State	Old	New	Status
chemical			Added