Soda vending ads and goodbyes

[Alpaccalypse]

About the PR

Gives all branded soda vendors their own advertising and purchase chatter.

Why / Balance

All soda vending machines share the same set of adverts and goodbyes, this can get quite repetitive and doesn't always make complete sense for the specific drinks that were vended. This makes each branded machine have its own set of advertising and purchase dialogue.

Technical details

• Adds new .ftl files for each branded vendor
• Edits vending_machines.yml, goodbyes.yml, and advertisements.yml as well as cola.ftl

A branch of #34182 as that has been approved, in an attempt to avoid unintentional conflicts.

Media

My favourite, thanks for the suggestion:

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
None. Flavour/cosmetic, with no impact on gameplay.

[Alpaccalypse]

Leaving this up as a draft because any suggestions or feedback for advertising lines are welcome, and I want to hold off on putting this up for review until related PRs have been reviewed. This is actually a branch of #34182 just to be sure I don't do anything stupid that totally messes with that one.

...I did something totally stupid that messed with that one...

[Alpaccalypse]

I'm trying hard to keep most of the dialogue to just a couple of words. Aiming for a punchy catch phrase kind of style. Trying not to exceed 30 characters at most, if possible. I'm also trying to resist doing too much trashing of other brands, though it is tempting, as I don't want to dilute the Dr. Gibb/Space Cola in-joke rivalry that has been subtly implicit in the game up to this point.

I'm quite pleased with the PWR Game set of chatter. I was trying to really lean into the "gamer" theme and satirise the culture a bit, especially in reference to real world drinks trying to attract this demographic. Hopefully the l33t spellings and references aren't too much.

Cola and Robust sets are fit for purpose I think, but might have some room for improvement. More brands incomming, but I didn't want to overthink it all in one go.

Oh yeah, and partly because thinking of 12 new lines for every machine can get tedious, and I thought it was a very mildly amusing and subtle reference, I was going to leave every machine saying "Over 1 million drinks sold!" except Robust which says "...10 million..." as they sell all brands, which make up a total of 10 at the moment.

[Alpaccalypse]

Tempted to see if I can make an appropriately lo-fi 10 note jingle that plays when you buy a can from the Shambler's Juice machine. Because of the implied jingle for the machine and reagent: ~ Shake me up some of that Shambler's Juice! ~

Todo:

• Robust Softdrinks (Just tweaking the default that was already there)
• Dr. Gibb
• Space Cola
• Fourteen Loko (Will be added with new machine)
• Sol Dry (Will be added with new machine)
• Red Bool (Will be added with new machine)
• PWR Game
• Space-Up!
• Smite (Will be added with new machine)
• Starkist
• Shambler's Juice

[Alpaccalypse]

Added Vlad's Salads references to PWR Game, which are intentionally out of tone with the rest of the chatter.

[Alpaccalypse]

Moved Star-kist vendor name fix from #34178 to avoid conflict.

[Alpaccalypse]

Added remaining adds, some reference to RL slogans of the satirised companies (changed to to be legally distinct).

Shambler's Juice was made to sound a little bit dodgy, (the flavor is "metallic" apparently) and the machine talks to you in the first person in places, and emphasises the "secret" nature of the ingredients.

[IWearKhakis]

Has it been already established what the "The taste of a star in liquid form. And, a bit of tuna...?" in the description of the Starkist soda can is referencing? Because #32934 seems to reference this fact with the addition of Carp burgers in the contraband inventory, and it made me think of two head-canons:

1. Starkist is run by (a) space dragon(s), much like how it's established that the CEO of Nanotrasen is also a space dragon
2. Starkist is run by/affiliated with a carp-fishing company that hunts carp and dragons, possibly for its ingredients? Space dragons do have Ichor which is a powerful healing reagent similar to omnizine and the description in the guidebook says its a exotic commodity, so it probably has some other unique manufacturing utilizations outside gameplay (Bigger fan of this one than the former)

[Alpaccalypse]

Has it been already established what the "The taste of a star in liquid form. And, a bit of tuna...?" in the description of the Starkist soda can is referencing?

Thanks for the ideas and link. I was wondering about this myself, I'll look into it. I didn't want to remove a reference, no matter how strange it sounded, and it makes sense not to just ignore it for this PR.

[Alpaccalypse]

Starkist now has the ad line "There's nothing fishy about Starkist!" and the buy line "The fish is just in your head."

[Alpaccalypse]

Added a couple of TF2 Heavy quotes and russian proverbs to the BODA vendor.

[Alpaccalypse]

Yeah, will fix it... internet cut out mid gitbashing and I think something strange started at that point, plus all my attempts to "fix" it a week ago.

Was hoping for a quick update before this happened. Gotta go for a bit but will fix this ASAP. Try a revert but if that doesn't work I'll just make a new PR, as this went wonky with Git before this latest fiasco. May well be what is causing the issues again.

[slarticodefast]

Uuh, I think it got worse somehow. That is a ton of commits.
At this point it might be easiest to make a new branch from master, copy paste your code over and open a new PR.

[Alpaccalypse]

I dunno why this one PR has been messing up with Git Bash so much, but I probably should have closed it and made a new one when Git started being weird with it weeks ago.