New dry fire sound #34447
New dry fire sound #34447
Conversation
github-actions
bot
added
S: Untriaged
|
For anyone wanting more examples of in-game audio, Delta-V also uses this sound effect for dry firing. |
| @@ -12,7 +12,7 @@ | |||
| "sfrifle_cock.ogg": "https://github.com/discordia-space/CEV-Eris/blob/01f7518e0f8177734a6579aba2bbf76024aa96c4/sound/weapons/guns/interact/sfrifle_cock.ogg" | |||
| }, | |||
| "Empty": { | |||
| "empty.ogg": "https://github.com/discordia-space/CEV-Eris/blob/fbde37a8647a82587d363da999a94cf02c2e128c/sound/weapons/guns/misc/gun_empty.ogg", | |||
| "empty.ogg": "https://github.com/tgstation/tgstation/blob/d4f678a1772007ff8d7eddd21cf7218c8e07bfc0/sound/weapons/gun_dry_fire.ogg", | |||
There was a problem hiding this comment.
Not your fault, but what the hell is this attribution format?
This doesn't even mention the licence the file is under and we probably should convert this into an attributions.yml format like we use everywhere else for audio. Not sure if this is a blocker for merging this PR.
There was a problem hiding this comment.
Yeah, this attribution format seems to have the goal of making it so that individual files can be attributed (how it should be!), instead of the giant, incredibly cursed, one-line "copyright" attributions that are prone to merge conflicts, seen in many of our meta.json's. I think there are... much much better ways of attributing these files though, like what's seen in attribution.yml's.
There was a problem hiding this comment.
Oh, and please change the link to the specific commit the file was taken from in case tg changes the audio file at a later point.
There was a problem hiding this comment.
Oh, and please change the link to the specific commit the file was taken from in case tg changes the audio file at a later point.
Done
ScarKy0
added
P3: Standard
About the PR
Why / Balance
Partially fixes #33189.
Uses the much louder dry fire sound from /tg/ station 13 and Delta-V, which audibly alerts both the shooter and nearby players. This reduces reliance on 'counting' bullets or looking at the UI to tell when the gun is empty, which should improve player responsiveness in combat.
Technical details
ogg changes only
Media
dotnet_0g4yRBbwQV.mp4
Requirements
Breaking changes
Changelog
🆑