Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow paper labels on seeds #34450

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

allow paper labels on seeds #34450

wants to merge 5 commits into from
+42 −11

Conversation

Ian321
Copy link
Contributor

@Ian321 Ian321 commented Jan 15, 2025 •
edited
Loading

About the PR

This PR add the ability to add a paper label to seeds.

Why / Balance

  • Seeds can have a wide variety of traits a botanist might want to document.
  • Preparation for future PR ("print" button on the plant analyzer)

Technical details

  • Added the PaperLabelComponent to SeedBase
  • Gave the base examine text for seeds the priority 1 so that it appears above the paper label.

Media

image

Requirements

Breaking changes

None

Changelog

🆑

  • add: Seeds can now have paper labels attached to them.

@Ian321 Ian321 requested a review from Partmedia as a code owner January 15, 2025 16:02
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 15, 2025
@beck-thompson
Copy link
Contributor

Great idea! Test fail is real though, I think you need to add an ItemSlots component on the seeds themselves so it doesn't automatically add it when its spawned.

@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: Service Area: Service department, including cooking, botany, etc and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 15, 2025
@beck-thompson beck-thompson self-assigned this Jan 15, 2025
Boaz1111
Boaz1111 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Boaz1111 Boaz1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in game, love the idea!

@Boaz1111 Boaz1111 added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 15, 2025
ScarKy0
ScarKy0 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good!
But could you change the changelog to something along the lines of "Seeds can now have paper labels attached to them"? I feel like the current one might be confused with the labeller

beck-thompson
beck-thompson requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah tested works great! The only actual change I think is important is to make the label appear on the item itself (Like lockers see this pr #33318). It shouldn't be too hard but if you need help ask here or the discord 🫡

Resources/Prototypes/Entities/Objects/Specific/Hydroponics/seeds.yml Outdated Show resolved Hide resolved
@Ian321
Copy link
Contributor Author

Ian321 commented Jan 15, 2025

image

@Ian321 Ian321 requested a review from beck-thompson January 15, 2025 21:23
@Boaz1111
Copy link
Contributor

You'll need a new sprite for the labels

@Ian321
Copy link
Contributor Author

Ian321 commented Jan 17, 2025

image

@github-actions github-actions bot added the Changes: Sprites Changes: Might require knowledge of spriting or visual design. label Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

RSI Diff Bot; head commit fa493a9 merging into e752561
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Hydroponics/seeds.rsi

State Old New Status
paper Added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boaz1111 Boaz1111 Boaz1111 approved these changes

@ScarKy0 ScarKy0 ScarKy0 approved these changes

@Partmedia Partmedia Awaiting requested review from Partmedia Partmedia is a code owner

@beck-thompson beck-thompson Awaiting requested review from beck-thompson

Requested changes must be addressed to merge this pull request.

Assignees

@beck-thompson beck-thompson

Labels
A: Service Area: Service department, including cooking, botany, etc Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ian321 @beck-thompson @Boaz1111 @ScarKy0