-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro Asteroid Sand #34463
base: master
Are you sure you want to change the base?
Astro Asteroid Sand #34463
Conversation
RSI Diff Bot; head commit 29fdc0f merging into 37bde33 Resources/Textures/Objects/Tiles/tile.rsi
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (blocking): You'll need to add attributions, and based on the very vague meta.json
, I'm assuming you add it to the attributions.yml
file in Resources/Textures/Tiles/attributions.yml
?
This doesn't really seem that optimal, but it seems like that's what people have do so far so... shrugs
If you wanted, I think it would be best if you just added the usual spiel to the meta.json
's copyright field and just leave the message saying the rest are in the other folder. That seems the most reasonable as none of the other inhands are not attributed and this is just a weird abuse of RGAs.
Yeah I was confused about that and couldn't find the attributions file when I skimmed the directory. You've fallen into my trap of finding it for me hehe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the attributions!
Just had another nitpick.
that works Co-authored-by: Thomas <[email protected]>
Co-authored-by: Thomas <[email protected]>
testfail fake but I gotta make some changes to the snow sprite too |
About the PR
Why / Balance
This is largely for Plasma Station #33991, but could also be utilized by any other map that wishes to use it.
Technical details
Copied preexisting astro-tiles and made the asteroid sand inherit from regular asteroid sand to preserve variants, sounds, etc.
Media
Image
This image is slightly out of date, the snow tiles look a little different
Video Demonstration
https://github.com/user-attachments/assets/1072243e-a941-452d-8957-7c2c90b1028a
Sprites for the tile entity and in-hands were made by myself. This video does showcase an older version of the sprites.
Requirements
Breaking changes
None that I know of.
Changelog
🆑 Southbridge