Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro Asteroid Sand #34463

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

southbridge-fur
Copy link
Contributor

@southbridge-fur southbridge-fur commented Jan 16, 2025

About the PR

  • Added astro-asteroid sand, to give a little more variety to astro landscapes.
  • Astro Asteroid Sand can be researched along with all the other astro tiles in the tier 2 civilian tech.
  • Modified astro-ice and astro-snow tiles since the art leads didn't like them

Why / Balance

This is largely for Plasma Station #33991, but could also be utilized by any other map that wishes to use it.

Technical details

Copied preexisting astro-tiles and made the asteroid sand inherit from regular asteroid sand to preserve variants, sounds, etc.

Media

Image

image
This image is slightly out of date, the snow tiles look a little different

Video Demonstration

https://github.com/user-attachments/assets/1072243e-a941-452d-8957-7c2c90b1028a
Sprites for the tile entity and in-hands were made by myself. This video does showcase an older version of the sprites.

Requirements

Breaking changes

None that I know of.

Changelog

🆑 Southbridge

  • add: Astro Asteroid Sand has been added as another type of faux tile.
  • add: Asteroid Astro Sand has also been added to the T2 civilian tech for the faux astro tiles.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. size/S Denotes a PR that changes 10-99 lines. labels Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

RSI Diff Bot; head commit 29fdc0f merging into 37bde33
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Tiles/tile.rsi

State Old New Status
astroice Modified
snow Modified
asteroid-inhand-left Added
asteroid-inhand-right Added
asteroid Added

Edit: diff updated after 29fdc0f

@ScarKy0 ScarKy0 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 16, 2025
Aeshus
Aeshus previously requested changes Jan 16, 2025
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (blocking): You'll need to add attributions, and based on the very vague meta.json, I'm assuming you add it to the attributions.yml file in Resources/Textures/Tiles/attributions.yml?

This doesn't really seem that optimal, but it seems like that's what people have do so far so... shrugs

https://github.com/space-wizards/space-station-14/blob/master/Resources/Textures/Tiles/attributions.yml

If you wanted, I think it would be best if you just added the usual spiel to the meta.json's copyright field and just leave the message saying the rest are in the other folder. That seems the most reasonable as none of the other inhands are not attributed and this is just a weird abuse of RGAs.

@southbridge-fur
Copy link
Contributor Author

issue (blocking): You'll need to add attributions, and based on the very vague meta.json, I'm assuming you add it to the attributions.yml file in Resources/Textures/Tiles/attributions.yml?

This doesn't really seem that optimal, but it seems like that's what people have do so far so... shrugs

https://github.com/space-wizards/space-station-14/blob/master/Resources/Textures/Tiles/attributions.yml

If you wanted, I think it would be best if you just added the usual spiel to the meta.json's copyright field and just leave the message saying the rest are in the other folder. That seems the most reasonable as none of the other inhands are not attributed and this is just a weird abuse of RGAs.

Yeah I was confused about that and couldn't find the attributions file when I skimmed the directory. You've fallen into my trap of finding it for me hehe

@Aeshus Aeshus self-requested a review January 17, 2025 02:16
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 17, 2025
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the attributions!

Just had another nitpick.

Resources/Prototypes/Stacks/floor_tile_stacks.yml Outdated Show resolved Hide resolved
@southbridge-fur
Copy link
Contributor Author

testfail fake but I gotta make some changes to the snow sprite too

@Aeshus Aeshus dismissed their stale review January 26, 2025 02:03

Changes addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants