-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AI should not have alt-menu option and alt-menu-related verb in drop-down menu as it have no options in it #34468
base: master
Are you sure you want to change the base?
Conversation
…drop-down menu as it have no options in it
Checked that all the default stuff (door interactions, consoles) still works for AI |
Tested in game and works |
@Errant-4 |
Hmm, i missed that part. I guess better fix it all at once? I think the solution would be to add some new field for Whitelist component and set it True only for doors... as they are the only ones who have interactions right now? I thought that consoles can be electrified too now that they have wires... |
Ideally the event for radials would say its empry and never give the verb unless theres associated menu options, but dunno how doable it is |
Thats also certainly doable - it'll just require sending event twice - first time for collecting verbs, second time to collect buttons. Maybe thats the right way. Gonna do it today/tomorrow |
That does sound like a better solution |
@slarticodefast It was already there, rider just removed a whitespace when I edited other parts of the file |
Well, funny thing - collecting actions for every console returns electrify option because it have ElectrifyComponent. I'm a bit puzzled why its there and how to approach this, to be perfectly honest. Sloth proposed to use stationaiwhitelist , maybe i'll add some flag there, we will see... |
Updated description with investigation details! |
About the PR
Now AI core doesn't have radial menu related verb on it. It had no options ready for radial menu (so if it could work, it would display just empty radial), and radial menu display couldn't work because it requires core to be powered using APC (which it is not).
Why / Balance
Useless option raised questions - look at https://discord.com/channels/310555209753690112/770682801607278632/1329502538591895676
Technical details
After short investigation the following was found:
To minimize possible side effects of changes in PR - i just added check, if required ui is missing on entity.
Media
before
after
Requirements
Breaking changes
none
Changelog
🆑 Fildrance