Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor station AI code cleanup #34476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor station AI code cleanup #34476

wants to merge 1 commit into from
+45 −78

Conversation

chromiumboy
Copy link
Contributor

About the PR

I noticed that there are some effectively duplicated methods in SharedStationSystem, so I've cleaned up the code

Why / Balance

N/A

Technical details

N/A

Media

N/A

Requirements

Breaking changes

  • SharedStationAiSystem.TryGetStationAiCore has been removed - replace any remaining instances with SharedStationAiSystem.TryGetCore(EntityUid entity, out Entity<StationAiCoreComponent?> core)
  • SharedStationAiSystem.TryGetHeldFromHolder has been removed - replace any remaining instances with SharedStationAiSystem.TryGetHeld(Entity<StationAiHolderComponent?> entity, out EntityUid held)
  • SharedStationAiSystem.TryGetInsertedAI has been removed - replace any remaining instances with SharedStationAiSystem.TryGetHeld(Entity<StationAiCoreComponent?> entity, out EntityUid held)

Changelog

N/A

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 17, 2025
@chromiumboy chromiumboy added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: Silicons Area: Relates to Silicon roles, including AI. size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Silicons Area: Relates to Silicon roles, including AI. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chromiumboy