Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paramedic Void Suit update #34657

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Paramedic Void Suit update #34657

wants to merge 31 commits into from
+114 −46

Conversation

Velken
Copy link
Contributor

@Velken Velken commented Jan 26, 2025 •
edited
Loading

About the PR

Moved the paramedic void suit outof the softsuit yml and moved it into the hardsuit yml
Made it restricted to medical (to be in line with the other deparment-specific hardsuits)
Added flashlight to its helmet
Added rotating blue light with siren sound to the suit (similar to the justice helmet)

Why / Balance

It was the only hardsuit (to my knowledge) that didn't have flashlight.
And being such a limited item per station, I though it would be nice to give it an ambulance siren.

Technical details

Moved ClothingOuterHardsuitVoidParamed and ClothingHeadHelmetVoidParamed from softsuit/EVA to the hardsuit .yml's
Added ambulancesiren.ogg and updated attributions .yml in its folder

Media

https://youtu.be/XnXVAvqczww

Note: the graphics in the video are outdated, the light is now from the side of the helmet instead of the antenna

Requirements

Breaking changes

Prototypes parenting off ClothingHeadHardsuitWithLightBase need to be reparented to use both ClothingHeadHardsuitBase AND ClothingHeadSuitWithLightBase

Changelog

🆑

  • add: Paramedic Void Suit now has flashlight and an ambulance siren.
  • tweak: Paramedic Void Suit is now restricted to Medical.

Velken added 2 commits January 26, 2025 08:13
@Velken
Made paramedic void suit into proper hardsuit (was softsuit before)
1ef15f0 
Added light to the paramedic void suit helmet
Added siren with light to the paramedic void suit
@Velken
Merge branch 'space-wizards:master' into paramedic-wee-woo
7ef8d01
@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: Audio Changes: Might require knowledge of audio. size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2025 •
edited
Loading

RSI Diff Bot; head commit b6a9d0d merging into ce10a1b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Head/Helmets/paramedhelm.rsi

State Old New Status
icon Removed
inhand-left Removed
inhand-right Removed

Resources/Textures/Clothing/Head/Hardsuits/paramedhelm.rsi

State Old New Status
equipped-head-light-vox Added
equipped-head-light Added
icon-flash Added
icon Added
light-overlay Added

Resources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi

State Old New Status
icon-siren Added

Edit: diff updated after b6a9d0d

@slarticodefast
Copy link
Member

slarticodefast commented Jan 26, 2025 •
edited
Loading

Isn't the difference between a soft and hardsuit the damage protection and slowdown?
So it would still be a softsuit since it gives no protection against brute damage.

@Velken
Copy link
Contributor Author

Velken commented Jan 26, 2025

Isn't the difference between a soft and hardsuit the damage protection and slowdown? So it would still be a softsuit since it gives no protection against brute damage.

The old code has a comment that says
"Despite having resistances and looking like a hardsuit, this parents off the EVA suit so it goes here."
The old one already has slowdown and protection values, just not for brute damage.
Plus, it looks and behaves more like a hardsuit than a softsuit.

@UbaserB
Copy link
Member

UbaserB commented Jan 26, 2025 •
edited
Loading

The light shouldn’t be on the antennae. The antennae is way too thin for that and serves a different function.

Also, should probably have a custom icon for the siren action.

@Velken
Copy link
Contributor Author

Velken commented Jan 26, 2025

The light shouldn’t be on the antennae. The antennae is way too thin for that and serves a different function.

Also, should probably have a custom icon for the siren action.

Where would you suggest the light be then?

@UbaserB
Copy link
Member

UbaserB commented Jan 26, 2025

IMG_6898

@Velken
Copy link
Contributor Author

Velken commented Jan 26, 2025

IMG_6898

ooooh, i like that, i'll update the sprite after in a bit and also make a custom icon for the siren

@Velken
Copy link
Contributor Author

Velken commented Jan 26, 2025

changed the light placement
but i couldn't figure out how to change the action bar icon for the siren

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Engineering Area: Engineering department, including Atmospherics. A: Medical Area: Medical department, including Chemistry and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Engineering Area: Engineering department, including Atmospherics. labels Jan 27, 2025
@Velken
Copy link
Contributor Author

Velken commented Jan 27, 2025 •
edited
Loading

fixed the siren icon, thanks to, Milon, KeronSHB and Orks (Beck T) on discord for helping out
2025-01-26-22 11 10-Content Client

@Velken
Copy link
Contributor Author

Velken commented Jan 29, 2025

latest siren:

2025-01-28.23-19-49.mp4

@Velken
ContainerContainerContainerContainerContainerContainerContainerContai…
f88671c 
…nerContainerContainerContainerContainerContainerContainer
Aeshus
Aeshus previously requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes I requested.

I just had a few more nitpicks and questions about where the light variant sprites are from.

Resources/Audio/Effects/Vehicle/attributions.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Clothing/Head/base_clothinghead.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Clothing/OuterClothing/hardsuits.yml Outdated Show resolved Hide resolved
Resources/Textures/Clothing/Head/Hardsuits/paramedhelm.rsi/icon-flash.png Outdated Show resolved Hide resolved
@Velken
attributions updated (turns out, i have to give myself credit when i …
d99c3a6 
…make stuff);

fixed identation;
moved action to Action/types.yml.
@Velken
Copy link
Contributor Author

Velken commented Jan 29, 2025

attributions updated (turns out, i have to give myself credit when i make stuff)
fixed identation
moved action to Action/types.yml

@Velken Velken requested a review from Aeshus January 29, 2025 18:10
@Aeshus Aeshus dismissed their stale review January 30, 2025 16:58

Review addressed

Aeshus
Aeshus reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Looks good to me.

@slarticodefast slarticodefast added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Feb 1, 2025
@Velken Velken requested a review from slarticodefast February 1, 2025 16:17
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Feb 1, 2025
@Velken
Copy link
Contributor Author

Velken commented Feb 1, 2025

changed siren sound again, made the suggested changes

@Velken
final final final final final for real final ambulancesiren.ogg chang…
df4c508 
…e pinky promise this time and if you don't like it, make a new PR yourself and offer a new sound
@Velken
Copy link
Contributor Author

Velken commented Feb 2, 2025

Final (pinky promise) change to the sound, recorded with game audio and PC audio at 100%
If you don't like it, please, by all means, go and make a PR to offer a better sound.
Unless you think is too quiet/loud, that is just a simple edit to the volume paramater in the softsuit yaml

2025-02-01.22-32-20.mp4

@Velken Velken requested a review from slarticodefast February 3, 2025 18:55
@walksanatora
Copy link

I like that low-tone sound. it wont destroy my eardrums when I inevibitaly leave it on for hours on end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aeshus Aeshus Aeshus left review comments

@ScarKy0 ScarKy0 ScarKy0 approved these changes

@Emisse Emisse Emisse approved these changes

@slarticodefast slarticodefast Awaiting requested review from slarticodefast

Requested changes must be addressed to merge this pull request.

Assignees

@ScarKy0 ScarKy0

Labels
A: Medical Area: Medical department, including Chemistry Changes: Audio Changes: Might require knowledge of audio. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Velken @slarticodefast @UbaserB @walksanatora @superjj18 @ScarKy0 @Emisse @Aeshus @ArtisticRoomba