Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake Mindshield Implant cleans itself up on draw #34718

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fake Mindshield Implant cleans itself up on draw #34718

wants to merge 3 commits into from
+8 −0

Conversation

poklj
Copy link
Contributor

@poklj poklj commented Jan 28, 2025 •
edited
Loading

About the PR

Fake mindshield (#34079) has a minor bug on draw where the implant drawing doesn't clean up the components added to the implanted entity.

Adding an event that's relayed to the implant when it's drawn and having the implant clean itself up solves this problem (and further allows other Implants to have unique draw effects

Why / Balance

Fixes a bug introduced with (#34079) where if you draw a Fake mindshield while it is toggled on, the Mindshield info icon will stay on.

Technical details

  • Give Fake mindshield a cleanup method, to remove the component added fixing a problem where the icon persists after implant draw

Media

Requirements

Breaking changes

Changelog

No CL No Fun

@poklj
Implant cleans itself up on draw
6609e7d 
- add an event to relay to an implant that it's being drawn,
to tell it to clean itself up

- Give Fake mindshield a cleanup method, to remove the component added
fixing a problem where the icon persists after implant draw
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Jan 28, 2025
@poklj poklj changed the title Implant cleans itself up on draw Fake Mindshield Implant cleans itself up on draw Jan 28, 2025
@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 28, 2025
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Jan 29, 2025
beck-thompson
beck-thompson approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🫡

@beck-thompson beck-thompson added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beck-thompson beck-thompson beck-thompson approved these changes

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poklj @beck-thompson @ArtisticRoomba