Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stop bleeding popup #34729

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

lzk228
Copy link
Contributor

@lzk228 lzk228 commented Jan 29, 2025

About the PR

show "You have stopped bleeding" or "Urist McHands has stopped bleeding" instead of always showing "They have stopped bleeding

Why / Balance

bad popups

Technical details

no

Media

before
Screenshot_20250129_055651

after
Screenshot_20250129_061342

Screenshot_20250129_061406

Requirements

Breaking changes

Changelog

no cl no fun

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Jan 29, 2025
@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 29, 2025
@lzk228 lzk228 requested a review from TheShuEd January 29, 2025 10:07
@TheShuEd TheShuEd added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 29, 2025
@slarticodefast slarticodefast merged commit 467b686 into space-wizards:master Jan 29, 2025
13 checks passed
@lzk228 lzk228 deleted the 01-29-fix-bleeding-popup branch January 29, 2025 13:15
widgetbeck pushed a commit to widgetbeck/imp-station-14 that referenced this pull request Jan 29, 2025
* fix stop bleeding popup

* add identity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants