Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CloneAppearance to Shared #35017

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Move CloneAppearance to Shared #35017

merged 2 commits into from
Feb 10, 2025

Conversation

poklj
Copy link
Contributor

@poklj poklj commented Feb 9, 2025

About the PR

Just move CloneAppearance from Server to Shared, Part of atomizing #34002

Why / Balance

Changeling's (#34002) Shared System requires the ability to modify someone's appearance, Functionally no other changes

Technical details

  • Move CloneAppearance from HumanoidAppearanceSystem to SharedHumanoidAppearanceSystem

Media

Requirements

Breaking changes

Changelog

No CL no Fun

@poklj
Move CloneAppearance
7d4b25d 
- Move CloneAppearance from HumanoidAppearanceSystem
to SharedHumanoidAppearanceSystem
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 9, 2025
@ArtisticRoomba ArtisticRoomba added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 9, 2025
ScarKy0
ScarKy0 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in-game and it works

@ScarKy0 ScarKy0 added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Feb 10, 2025
@slarticodefast slarticodefast merged commit 8b46538 into space-wizards:master Feb 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FairlySadPanda FairlySadPanda FairlySadPanda left review comments

@ScarKy0 ScarKy0 ScarKy0 approved these changes

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@poklj @FairlySadPanda @ScarKy0 @slarticodefast @ArtisticRoomba