Skip to content

Unpredict MagnetPickupSystem.cs #39988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Unpredict MagnetPickupSystem.cs #39988

wants to merge 2 commits into from
+6 −1

Conversation

kosticia
Copy link
Contributor

About the PR

This pr unpredicts update method in the MagnetPickupSystem.cs.

Why / Balance

Right now its causes problems with prediction and looks awful ingame.

Technical details

Added _net.IsClient check to the MagnetPickupSystem.cs

Media

Before:

after.mp4

After:

before.mp4

Requirements

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS Denotes a PR that changes 0-9 lines. labels Aug 30, 2025
slarticodefast
slarticodefast requested changes Aug 30, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should fix the prediction instead.
NextScan needs AutoNetworkedField and dirtying after being changed.

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 30, 2025
@VerinSenpai VerinSenpai added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. A: Cargo/Salvage Area: Cargo department or Salvage. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 30, 2025
@kosticia
Copy link
Contributor Author

kosticia commented Aug 30, 2025 •
edited
Loading

You should fix the prediction instead. NextScan needs AutoNetworkedField and dirtying after being changed.

Yep, now it looks cleaner, but it doesn't fixes main problem: animation still plays twice. Looks like it because stack system still uses server-side deletion only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A: Cargo/Salvage Area: Cargo department or Salvage. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Awaiting Changes Status: Changes are required before another review can happen size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kosticia @slarticodefast @PJBot @VerinSenpai