Skip to content

Move BrainSystem and necessary components to Shared #40499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move BrainSystem and necessary components to Shared #40499

wants to merge 1 commit into from

Conversation

VerinSenpai
Copy link
Contributor

@VerinSenpai VerinSenpai commented Sep 22, 2025 •
edited
Loading

About the PR

Gave the brain system the ole 1-2. Very helpful about, I know.

Why / Balance

Needed for admin verb prediction. See #39550

Technical details

Moved BrainSystem, BrainComponent, and GhostOnMoveComponent to Shared. Made GhostOnMoveComponent networked and added a dirty for that component in BrainSystem. What will you use this new found power for? HMMM????

Requirements

Breaking changes

GhostOnMoveComponent is now in the Content.Shared.Ghost namespace. Usages of this component will need updated.

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. labels Sep 22, 2025
@VerinSenpai VerinSenpai added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. T: Prediction Type: Moving code to Content.Shared and making it predicted. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Sep 22, 2025
@VerinSenpai VerinSenpai mentioned this pull request Sep 22, 2025
Open
2 tasks
@ToastEnjoyer
Copy link
Contributor

Brain in... shared? A hivemind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. T: Prediction Type: Moving code to Content.Shared and making it predicted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VerinSenpai @ToastEnjoyer @PJBot