HLA-1537: Remove rounding of IDCSCALE #2063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change, I believe, will have an effect only on SVM and MVM generation. Are there any SVM or MVM tests in the regular regression test run, linked above? |
There are no MVM tests, but the regression test linked in the initial comment of this PR include SVM tests: Regression tests passing: Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HLA-1537
Closes #2051
This PR removes the rounding for IDSCALE, which is the pixel scale of the IDCTAB (distortion correction). It seems that rounding this value to three digits may have a small impact on accuracy during the astrodrizzle step. The original contribution of the code did not have any additional context for rounding the value (#1005).
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionRegression tests passing: Link