Skip to content

HLA-1537: Remove rounding of IDCSCALE #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+3 −1
Open

HLA-1537: Remove rounding of IDCSCALE #2063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
de0776d
initial commit.
s-goldman Aug 21, 2025
71e0e98
remove rounding amount.
s-goldman Aug 21, 2025
724eaca
added changelog entry.
s-goldman Aug 21, 2025
9a9e6f7
Merge branch 'main' into hla-1537_remove_rounding_from_idcscale_08_21_25
s-goldman Sep 11, 2025
9bdaf31
Merge branch 'main' into hla-1537_remove_rounding_from_idcscale_08_21_25
s-goldman Sep 11, 2025
53420fd
Merge branch 'main' into hla-1537_remove_rounding_from_idcscale_08_21_25
s-goldman Sep 22, 2025
eeb0ae4
Merge branch 'main' into hla-1537_remove_rounding_from_idcscale_08_21_25
s-goldman Sep 29, 2025
bdcb3a6
Merge branch 'main' into hla-1537_remove_rounding_from_idcscale_08_21_25
s-goldman Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ number of the code change for that issue. These PRs can be viewed at:
3.xx.x (unreleased)
===================

- Removed rounding of IDCSCALE values. [#2063]

- Fixed metawcs ecsv filename issue and removed lingering files. [#2073]

- Removed deprecated functions in align.py and related HAP tests. [#2072]
Expand Down
2 changes: 1 addition & 1 deletion drizzlepac/runastrodriz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,7 +2234,7 @@ def _update_idcscale(filename):
if fhdu_idscale is None:
cd11 = hdul[('sci', sciext + 1)].header['CD1_1']
cd21 = hdul[('sci', sciext + 1)].header['CD2_1']
fhdu_idscale = round(np.sqrt(np.power(cd11, 2) + np.power(cd21, 2)) * 3600., 3)
fhdu_idscale = np.sqrt(np.power(cd11, 2) + np.power(cd21, 2)) * 3600
# Set the value of the IDCSCALE keyword
for extn in range(num_sci):
msg = 'Adding IDCSCALE {} to {}[sci,{}]'.format(fhdu_idscale, hdul.filename(), extn + 1)
Expand Down