Skip to content

Conversation

@tpadioleau
Copy link
Contributor

  • remove the always in conflict variant cxxstd=11
  • add variant cxxstd=23 starting from Kokkos 4

@tpadioleau
Copy link
Contributor Author

tpadioleau commented Dec 10, 2025

  • Should we continue adding conflicts with CUDA, like conflicts("+cuda", when="cxxstd=23") ? I think if one wants to compile with CUDA clang++, it should work ? I think this limitation only concerns nvcc ?
  • Not a big fan of the fix for HPX in C++23...

Copy link
Member

@rbberger rbberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of operating with conflicts, we could adopt what is described here: https://spack.readthedocs.io/en/latest/packaging_guide_creation.html#conditional-possible-values

@tpadioleau
Copy link
Contributor Author

In a previous gitlab run, there was an issue with vtk-m, likely not supporting C++20 yet (but also likely not a big bug). What should we do about it ?

@cedricchevalier19
Copy link
Contributor

In a previous gitlab run, there was an issue with vtk-m, likely not supporting C++20 yet (but also likely not a big bug). What should we do about it ?

Was it with kokkos 4? If so, they should add a conflict in their recipe.
I am not sure that it is maintained now as the upstream project is now viskores.

@tpadioleau
Copy link
Contributor Author

In a previous gitlab run, there was an issue with vtk-m, likely not supporting C++20 yet (but also likely not a big bug). What should we do about it ?

Was it with kokkos 4? If so, they should add a conflict in their recipe. I am not sure that it is maintained now as the upstream project is now viskores.

It was Kokkos 5 that triggered the use of C++20.

@lucbv
Copy link
Contributor

lucbv commented Jan 6, 2026

We can reach out to the vtk-m/viskores maintainers if necessary, considering the project went through some changes they might want to clean things up and deprecate old things as well.
I like the current changes, it looks clean, thanks @tpadioleau !

@tpadioleau
Copy link
Contributor Author

Given #2945, I am in favor to wait.

@tpadioleau tpadioleau force-pushed the kokkos-cxxstd-cleanup branch from 8f59ad9 to 71890db Compare January 8, 2026 15:39
@rbberger
Copy link
Member

rbberger commented Jan 9, 2026

@tpadioleau more cleanup: #2994

@rbberger
Copy link
Member

rbberger commented Jan 9, 2026

@tpadioleau fingers crossed for the next rebase ;-)

@tpadioleau tpadioleau force-pushed the kokkos-cxxstd-cleanup branch from 71890db to 4276c2e Compare January 9, 2026 22:32
@rbberger rbberger merged commit e313d64 into spack:develop Jan 10, 2026
17 checks passed
@tpadioleau tpadioleau deleted the kokkos-cxxstd-cleanup branch January 10, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants