-
Notifications
You must be signed in to change notification settings - Fork 512
kokkos: cxxstd cleanup #2721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kokkos: cxxstd cleanup #2721
Conversation
tpadioleau
commented
Dec 10, 2025
- remove the always in conflict variant cxxstd=11
- add variant cxxstd=23 starting from Kokkos 4
|
rbberger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of operating with conflicts, we could adopt what is described here: https://spack.readthedocs.io/en/latest/packaging_guide_creation.html#conditional-possible-values
67d6307 to
57a47c4
Compare
57a47c4 to
294c2ce
Compare
2f5b045 to
c73d777
Compare
c73d777 to
8f59ad9
Compare
|
In a previous gitlab run, there was an issue with vtk-m, likely not supporting C++20 yet (but also likely not a big bug). What should we do about it ? |
Was it with kokkos 4? If so, they should add a conflict in their recipe. |
It was Kokkos 5 that triggered the use of C++20. |
|
We can reach out to the vtk-m/viskores maintainers if necessary, considering the project went through some changes they might want to clean things up and deprecate old things as well. |
|
Given #2945, I am in favor to wait. |
8f59ad9 to
71890db
Compare
|
@tpadioleau more cleanup: #2994 |
|
@tpadioleau fingers crossed for the next rebase ;-) |
71890db to
4276c2e
Compare