vtk-m: add conflict for Kokkos 5 #2994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tpadioleau
approved these changes
Jan 9, 2026
Contributor
tpadioleau
left a comment
tpadioleau
left a comment
There was a problem hiding this comment.
Looks good to me.
I wanted to consider depends_on("kokkos@:4", when="+kokkos") but I am not sure how to interpret depends_on("[email protected]:3.9", when="@2.0 +kokkos"), why is it specific to 2.0.x ?
kmorel
approved these changes
Jan 9, 2026
Contributor
|
I agree with your assessment. Applications still using VTK-m would have to be updated to Viskores, but this will be expected going forward. I don't see a reason to patch VTK-m to use C++20 unless there is a compelling use case for that. |
johnwparent
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kokkos 5 requires C++20. vtk-m fails to compile with it. I was considering explicitly directing people to use viskores, but I don't know too much about it and how compatible they are.
Note
Viskores has the appropriate changes for C++20, so should probably be used moving forward. See this changelog.