Skip to content

Precheck fail on old builtin #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tldahlgren wants to merge 3 commits into from
Closed

Precheck fail on old builtin #526

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af8c92b
precheck: ensure packages not being added to the old builtin dir
tldahlgren Jul 8, 2025
2f1b4fa
Remove test packages
tldahlgren Jul 9, 2025
37a5984
Fix the name associated with the check.
tldahlgren Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/prechecks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,28 @@ concurrency:


jobs:
# Ensure no changes involve the old builtin repository directory
check-builtin-dir:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
with:
fetch-depth: 2
- name: Get changed files
run: |
commits="$(git rev-list --all)"
readarray -t <<< $commits
changed_files=$(git diff --name-only --diff-filter=d ${MAPFILE[-1]}..${MAPFILE[0]})
OLD_BUILTIN="var/spack/repos/spack_repo/builtin"
NEW_BUILTIN="repos/spack_repo/builtin"
if echo "$changed_files" | grep -q "$OLD_BUILTIN"; then
echo "Error: Packages are not allowed in '$OLD_BUILTIN'."
echo " Use '$NEW_BUILTIN' instead."
exit 1
else
echo "Info: '$OLD_BUILTIN' is not being used"
fi

# Validate that the code can be run on all the Python versions supported by Spack
validate:
runs-on: ubuntu-latest
Expand Down
Loading