Precheck fail on old builtin #526
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tldahlgren
force-pushed
the
precheck_fail_on_old_builtin
branch
2 times, most recently
from
83a13c6 to
b2f51c9
Compare
tldahlgren
changed the title
tldahlgren
force-pushed
the
precheck_fail_on_old_builtin
branch
4 times, most recently
from
f7a4417 to
9fbbf78
Compare
Signed-off-by: Tamara Dahlgren <[email protected]>
Signed-off-by: Tamara Dahlgren <[email protected]>
tldahlgren
force-pushed
the
precheck_fail_on_old_builtin
branch
from
c196d4a to
2f1b4fa
Compare
tldahlgren
changed the title
Contributor
|
Can you link the failing check? |
Contributor
Author
Do you mean when it failed due to the addition of the test files? |
Contributor
Author
If so, the failing run (before a couple of minor output tweaks on error output) is at https://github.com/spack/spack-packages/actions/runs/16158268521/job/45604955251#step:3:22. Or, if you mean success output, that can be seen at https://github.com/spack/spack-packages/actions/runs/16158377716/job/45605249261?pr=526. |
tldahlgren
commented
Jul 9, 2025
Contributor
Author
|
Superseded by #542 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of PRs pulled from
spack/spackthat were adding new packages under the oldbuiltindirectory structure. The goal here is to add a precheck that fails if any files are added under that structure.