Skip to content

Conversation

@tldahlgren
Copy link
Contributor

@tldahlgren tldahlgren commented Jul 14, 2025

Fixes #591

#542 added a check for one of the old builtin repository paths. This PR adds another that's been encountered in PRs.

An example of the new output can be seen at https://github.com/spack/spack-packages/actions/runs/16279170198/job/45965108609?pr=584.

...
Error: Builtin packages are no longer allowed under 'var/spack/repos/'.
       The following files need to be moved to the appropriate
       subdirectory of 'repos/spack_repo/builtin':

  var/spack/repos/builtin/remove-me/package.py
  ...

@tldahlgren tldahlgren force-pushed the update_changes_builtin_check branch 4 times, most recently from e35ca2d to 822390b Compare July 14, 2025 22:14
@tldahlgren tldahlgren changed the title Changes: also pick up an older builtin repo path CI check/changes: also pick up an older builtin repo path Jul 14, 2025
@tldahlgren tldahlgren force-pushed the update_changes_builtin_check branch 2 times, most recently from e994250 to 21d8fe1 Compare July 14, 2025 22:22
@tldahlgren tldahlgren changed the title CI check/changes: also pick up an older builtin repo path ci / changes: also pick up an older builtin repo path Jul 14, 2025
Signed-off-by: tldahlgren <[email protected]>
@tldahlgren tldahlgren force-pushed the update_changes_builtin_check branch from 21d8fe1 to 8732c25 Compare July 14, 2025 22:24
@tldahlgren tldahlgren marked this pull request as ready for review July 14, 2025 22:25
@haampie haampie merged commit 61afa0a into spack:develop Jul 16, 2025
14 of 15 checks passed
@tldahlgren tldahlgren deleted the update_changes_builtin_check branch July 16, 2025 15:42
jezwilkinson pushed a commit to jezwilkinson/spack-packages that referenced this pull request Jul 21, 2025
mtaillefumier pushed a commit to mtaillefumier/spack-packages that referenced this pull request Jul 23, 2025
hfbauman pushed a commit to hfbauman/spack-packages that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci / changes: need to disallow use of older builtin repository directories

2 participants