Skip to content

ci / changes: also pick up an older builtin repo path #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haampie merged 3 commits into from
Jul 16, 2025
Merged

ci / changes: also pick up an older builtin repo path #584

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbd2fc1
Changes: also pick up an older builtin repo path
tldahlgren Jul 14, 2025
8732c25
List the offending files
tldahlgren Jul 14, 2025
f09441b
Feedback: simply check for 'var/spack/repos' use
tldahlgren Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,20 @@ jobs:
- .ci/env
packages:
- repos/spack_repo/**
old-builtin:
- 'var/spack/repos/spack_repo/builtin/**'
- name: Detected old builtin repository
if: steps.filter.outputs.old-builtin == 'true'
old_repos:
- 'var/spack/repos/**'
list-files: 'shell'
- name: Detected old package repository root directory
if: steps.filter.outputs.old_repos == 'true'
run: |
echo "Error: Packages are not allowed in 'var/spack/repos/spack_repo/builtin'."
echo " Use 'repos/spack_repo/builtin' instead."
files=${{ steps.filter.outputs.old_repos_files }}
echo "Error: Packages are no longer allowed under 'var/spack/repos/'."
echo " The following files need to be moved to the appropriate"
echo " subdirectory of 'repos/spack_repo/builtin':"
echo
for f in $files; do
echo " $f"
done
exit 1

unit-tests:
Expand Down
Loading