-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update matrix-appservice-irc
version
#3512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
roles/custom/matrix-bridge-appservice-irc/templates/config.yaml.j2
Outdated
Show resolved
Hide resolved
Setting up media proxy is a bit above my level |
I have rebased this, but would appreciate some help getting the authenticated media set up correctly |
53e5e12
to
f83dbce
Compare
It seems that the media proxy is indeed part of the bridge, but that you need to set up e.g. traefik to route traffic to it. This is well above my paygrade. |
6de981e
to
bea4169
Compare
77980f9
to
34fab8b
Compare
@thomwiggers I had a shot at the traefik changes, not really tested though: https://github.com/JadedBlueEyes/matrix-docker-ansible-deploy/tree/patch-11 |
Thanks, that does look plausible... I hope I will have some time to test it. |
The following gets posted to IRC
But following it just gets a 404 :( I haven't had time to dig into the logs yet. |
The Traefik GUI dashboard is likely to show more hints |
The Traefik GUI says the rule is |
Using
which appears to result from the bridge, because:
|
Going off matrix-org/matrix-appservice-irc#1828 it may be that |
34fab8b
to
27e320f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consistency changes required
|
||
matrix_appservice_irc_homeserver_url: "" | ||
matrix_appservice_irc_homeserver_media_url: '{{ matrix_homeserver_url }}' | ||
matrix_appservice_irc_homeserver_media_url: '{{ matrix_homeserver_url }}/irc/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matrix_appservice_irc_homeserver_media_domain: '{{ matrix_server_fqn_matrix }}'
matrix_appservice_irc_homeserver_media_path: '/irc/'
|
||
# Controls whether Traefik labels for the media proxy will be applied | ||
matrix_appservice_irc_container_labels_media_proxy_enabled: true | ||
matrix_appservice_irc_container_labels_traefik_path_prefix: "/irc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matrix_appservice_irc_container_labels_traefik_path_prefix: "/irc" | |
matrix_appservice_irc_container_labels_traefik_path_prefix: "{{ matrix_appservice_irc_homeserver_media_domain }}" |
# Controls whether Traefik labels for the media proxy will be applied | ||
matrix_appservice_irc_container_labels_media_proxy_enabled: true | ||
matrix_appservice_irc_container_labels_traefik_path_prefix: "/irc" | ||
matrix_appservice_irc_container_labels_media_proxy_traefik_rule: "Host(`{{ matrix_server_fqn_matrix }}`) && PathPrefix(`{{ matrix_appservice_irc_container_labels_traefik_path_prefix }}`)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matrix_appservice_irc_container_labels_media_proxy_traefik_rule: "Host(`{{ matrix_server_fqn_matrix }}`) && PathPrefix(`{{ matrix_appservice_irc_container_labels_traefik_path_prefix }}`)" | |
matrix_appservice_irc_container_labels_media_proxy_traefik_rule: "Host(`{{ matrix_appservice_irc_homeserver_media_domain }}`) && PathPrefix(`{{ matrix_appservice_irc_container_labels_traefik_path_prefix }}`)" |
# The port for the media proxy to listen on | ||
bindPort: {{ matrix_appservice_irc_homeserver_media_bind_port | to_json }} | ||
# The publically accessible URL to the media proxy | ||
publicUrl: "{{ matrix_appservice_irc_homeserver_media_url }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publicUrl: "{{ matrix_appservice_irc_homeserver_media_url }}" | |
publicUrl: "https://{{ matrix_appservice_irc_homeserver_media_domain }}{{ matrix_appservice_irc_homeserver_media_path }}" |
The update to
3.0
brings with it that it now uses MediaProxy.