Uganda Country Updates - Holiday Start Dates and Eid Date computation #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Estonian holidays * Use easter() method for easter date
contructor -> constructor
Co-authored-by: Ariful Alam <[email protected]>
* feat(Mexico.php): rebase main to put mandatory days * feat(Mexico.php): finished dates
Closed
| @@ -3,6 +3,8 @@ | |||
| namespace Spatie\Holidays\Countries; | |||
|
|
|||
| use Carbon\CarbonImmutable; | |||
| use GeniusTS\HijriDate\Date; | |||
There was a problem hiding this comment.
I prefer to not use this library for following reasons:
There was a problem hiding this comment.
You can look at Turkey or Egypt and how they solved Islamic holidays
|
Thanks, but I'm closing this PR as it doesn't feel complete yet. Feel free to reopen once fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of the Uganda holidays to take into account the start dates of the holidays going in the past and computation of Eid using the Islamic calendar