-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uganda Country Updates - Holiday Start Dates and Eid Date computation #142
Conversation
* Add Estonian holidays * Use easter() method for easter date
contructor -> constructor
Co-authored-by: Ariful Alam <[email protected]>
* feat(Mexico.php): rebase main to put mandatory days * feat(Mexico.php): finished dates
@@ -3,6 +3,8 @@ | |||
namespace Spatie\Holidays\Countries; | |||
|
|||
use Carbon\CarbonImmutable; | |||
use GeniusTS\HijriDate\Date; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to not use this library for following reasons:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can look at Turkey or Egypt and how they solved Islamic holidays
Thanks, but I'm closing this PR as it doesn't feel complete yet. Feel free to reopen once fixed! |
Extension of the Uganda holidays to take into account the start dates of the holidays going in the past and computation of Eid using the Islamic calendar