Add Holidays - Pakistan #19
Conversation
muhammad-nauman
force-pushed
the
pakistan
branch
from
f870442
to
61366c5
Compare
|
@Nielsvanpach I do not understand the reason behind the failing action, can you help me with that? |
muhammad-nauman
force-pushed
the
pakistan
branch
from
3f4a690
to
e7d7cc9
Compare
muhammad-nauman
force-pushed
the
pakistan
branch
from
e7d7cc9
to
1b25080
Compare
| /** @return array<string, CarbonImmutable> */ | ||
| protected function variableHolidays(int $year): array | ||
| { | ||
| // The variable holidays are all follow lunar calendar so their dates are not confirmed. |
There was a problem hiding this comment.
You can look at how Turkey solved this:
https://github.com/spatie/holidays/blob/main/src/Countries/Turkey.php#L11
There was a problem hiding this comment.
I checked the implementation, the solution provides the dates but there is no surety that the calendar will follow thsoe exact dates. Should I go for it anyway?
There was a problem hiding this comment.
I wouldn't copy-paste the Turkey solution. But a similar approach can be done for Pakistan?
There was a problem hiding this comment.
@Nielsvanpach I tried adapting the solution. The problem is, that we have 4 different sets of holidays that follow the lunar calendar(total of 10 holidays) and it is making the code a lot more complex and even after that, the dates will not be accurate.
Co-authored-by: Niels Vanpachtenbeke <[email protected]>
|
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
Overview:
This pull request adds the country class for Pakistan. It lists the fixed federal holidays from the list here.
All the relevant test files are also added.