-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NYP: added Pakistani holidays and test case #99
Conversation
NabeelYousafPasha
commented
Jan 18, 2024
- Added all Pakistani public holidays
- Left Islamic Holidays as they are lunar and region bases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Did you verify if the generated results in the snapshot are correct?
@Nielsvanpach Yes, I verified those.
|
@NabeelYousafPasha can you please close this in favor of #19 as per the guidelines? |
Closing this PR as #19 covers Pakistan Holidays. Thanks @muhammad-nauman for your contribution |
Thanks @NabeelYousafPasha . Appreciated! |