Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NYP: added Pakistani holidays and test case #99

Closed
wants to merge 3 commits into from

Conversation

NabeelYousafPasha
Copy link

  • Added all Pakistani public holidays
  • Left Islamic Holidays as they are lunar and region bases

Copy link
Member

@Nielsvanpach Nielsvanpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did you verify if the generated results in the snapshot are correct?

src/Countries/Pakistan.php Outdated Show resolved Hide resolved
src/Countries/Pakistan.php Outdated Show resolved Hide resolved
src/Countries/Pakistan.php Outdated Show resolved Hide resolved
@muhammad-nauman
Copy link
Contributor

muhammad-nauman commented Jan 19, 2024

@NabeelYousafPasha
Copy link
Author

NabeelYousafPasha commented Jan 19, 2024

Thanks! Did you verify if the generated results in the snapshot are correct?

@Nielsvanpach Yes, I verified those.
Snapshot content attached as well.

[ { "name": "Kashmir Solidarity Day", "date": "2024-02-05" }, { "name": "Pakistan Resolution Day", "date": "2024-03-23" }, { "name": "Labour Day", "date": "2024-05-01" }, { "name": "Independence Day", "date": "2024-08-14" }, { "name": "Defence Day", "date": "2024-09-06" }, { "name": "Iqbal Day", "date": "2024-11-09" }, { "name": "Quaid-e-Azam Day", "date": "2024-12-25" } ]

@muhammad-nauman
Copy link
Contributor

@NabeelYousafPasha can you please close this in favor of #19 as per the guidelines?
Thanks!

@NabeelYousafPasha
Copy link
Author

Closing this PR as #19 covers Pakistan Holidays.

Thanks @muhammad-nauman for your contribution

@muhammad-nauman
Copy link
Contributor

Thanks @NabeelYousafPasha . Appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants