DUI33 289 investigate and create versioning poc #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type cache, which (if it works as expected) I think is a bit more efficient
- Removed most Kit references
added 2 commits
July 2, 2024 19:31
…n if it exists next steps: - get the version from the commit - pick a version to use if there isn't one... what would this be? hmmm should be oldest version? want to avoid duplicating the world at this stage :D - add in the conversion logic, registering the type upgrader and picking upgrades to return the actual type we want to load
- being passed along to Dict2Base() where it can be used to pick the right deserialisation target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step with object upgrading had to be the (unexpected) act of excising Kits from the SDK. Most of Kits has now gone, what remains appears to be largely unrelated to kits.
Type Caching is now done with a new ITypeCache, an AbstractTypeCache and and ObjectsTypeCache. In theory, because this is injected down to Receive, it is possible to continue doing a kits like thing, by passing in a different TypeCache. By default the ObjectsTypeCache is caching all types that are derived from Base and found in the assembly where ObjectsTypeCache exists and the base, i.e. looking in Core and Objects. This might be something we can do a bit more elegantly but it's definitely no worse than existing.
Note that some changes may relate to working with the SDK and the connectors at the same time.